From: Victor Julien <victor@inliniac.net>
Date: Thu, 25 Oct 2018 09:55:05 +0000 (+0200)
Subject: mpm: fix minor scan-build warning
X-Git-Tag: suricata-4.1.0~18
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e22a833b948a8476d89fc40297404f6e72e830e3;p=thirdparty%2Fsuricata.git

mpm: fix minor scan-build warning
---

diff --git a/src/util-mpm.c b/src/util-mpm.c
index 0dfe1793ba..12e9f0f32c 100644
--- a/src/util-mpm.c
+++ b/src/util-mpm.c
@@ -457,7 +457,7 @@ static inline int MpmInitHashAdd(MpmCtx *ctx, MpmPattern *p)
     uint32_t hash = MpmInitHash(p);
 
     if (ctx->init_hash == NULL) {
-        return 0;
+        return -1;
     }
 
     if (ctx->init_hash[hash] == NULL) {
@@ -559,7 +559,8 @@ int MpmAddPattern(MpmCtx *mpm_ctx, uint8_t *pat, uint16_t patlen,
         }
 
         /* put in the pattern hash */
-        MpmInitHashAdd(mpm_ctx, p);
+        if (MpmInitHashAdd(mpm_ctx, p) != 0)
+            goto error;
 
         mpm_ctx->pattern_cnt++;