From: James Jones <jejones3141@gmail.com>
Date: Mon, 21 Aug 2023 19:02:21 +0000 (-0500)
Subject: Reassure coverity (CID #1504052) (#5152)
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e23d2ca9de3e802a609b57455bfc9fda9ed65b99;p=thirdparty%2Ffreeradius-server.git

Reassure coverity (CID #1504052) (#5152)

Non-group structural type attributes may always have a namespace
hash table, but coverity can't figure that out.
---

diff --git a/src/lib/util/dict_util.c b/src/lib/util/dict_util.c
index dda40b6aad4..eeff7600c60 100644
--- a/src/lib/util/dict_util.c
+++ b/src/lib/util/dict_util.c
@@ -4261,6 +4261,8 @@ void fr_dict_attr_verify(char const *file, int line, fr_dict_attr_t const *da)
 	switch (da->type) {
 	case FR_TYPE_STRUCTURAL:
 	{
+		fr_hash_table_t *ht;
+
 		if (da->type == FR_TYPE_GROUP) break;
 
 		fr_assert_msg(fr_dict_attr_has_ext(da, FR_DICT_ATTR_EXT_CHILDREN),
@@ -4276,8 +4278,9 @@ void fr_dict_attr_verify(char const *file, int line, fr_dict_attr_t const *da)
 		/*
 		 *	Check the namespace hash table is ok
 		 */
-		/* coverity[dereference] */
-		fr_hash_table_verify(dict_attr_namespace(da));
+		ht = dict_attr_namespace(da);
+		if (unlikely(!ht)) break;
+		fr_hash_table_verify(ht);
 	}
 		break;