From: Alan T. DeKok <aland@freeradius.org>
Date: Tue, 9 Nov 2021 20:14:59 +0000 (-0500)
Subject: no need to print the name
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e241897035b036485c536396dad40957ab028424;p=thirdparty%2Ffreeradius-server.git

no need to print the name

the module isn't going away until after it's data has been freed.
---

diff --git a/src/lib/server/dl_module.c b/src/lib/server/dl_module.c
index d9b36408af9..517d3482267 100644
--- a/src/lib/server/dl_module.c
+++ b/src/lib/server/dl_module.c
@@ -283,7 +283,7 @@ static void dl_module_instance_data_alloc(dl_module_inst_t *dl_inst, dl_module_t
 	if (!module->common->inst_type) {
 		talloc_set_name(data, "%s_t", module->dl->name ? module->dl->name : "config");
 	} else {
-		talloc_set_name(data, "%s", module->common->inst_type);
+		talloc_set_name_const(data, module->common->inst_type);
 	}
 	dl_inst->data = data;
 
diff --git a/src/lib/server/module.c b/src/lib/server/module.c
index c3c8c58a6c0..0338591ce9f 100644
--- a/src/lib/server/module.c
+++ b/src/lib/server/module.c
@@ -1260,7 +1260,7 @@ int modules_thread_instantiate(TALLOC_CTX *ctx, fr_event_list_t *el)
 			if (!mi->module->thread_inst_type) {
 				talloc_set_name(ti->data, "rlm_%s_thread_t", mi->module->name);
 			} else {
-				talloc_set_name(ti->data, "%s", mi->module->thread_inst_type);
+				talloc_set_name_const(ti->data, mi->module->thread_inst_type);
 			}
 		}