From: Jason Parker <jparker@digium.com>
Date: Wed, 27 Sep 2006 19:35:09 +0000 (+0000)
Subject: Playback() wasn't setting PLAYBACKSTATUS under several circumstances.
X-Git-Tag: 1.2.13~42
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e247b8ab33dec9db6a7eb99c236bf6a1d058b32e;p=thirdparty%2Fasterisk.git

Playback() wasn't setting PLAYBACKSTATUS under several circumstances.
Playback() returns -1 on missing args - so should Background()


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43800 65c4cc65-6c06-0410-ace0-fbb531ad65f3
---

diff --git a/apps/app_playback.c b/apps/app_playback.c
index ed33097ab3..71c9bc743c 100644
--- a/apps/app_playback.c
+++ b/apps/app_playback.c
@@ -110,6 +110,7 @@ static int playback_exec(struct ast_channel *chan, void *data)
 	if (chan->_state != AST_STATE_UP) {
 		if (option_skip) {
 			/* At the user's option, skip if the line is not up */
+			pbx_builtin_setvar_helper(chan, "PLAYBACKSTATUS", "SUCCESS");
 			LOCAL_USER_REMOVE(u);
 			return 0;
 		} else if (!option_noanswer)
@@ -137,11 +138,11 @@ static int playback_exec(struct ast_channel *chan, void *data)
 			}
 			front = back;
 		}
-		if (mres)
-			pbx_builtin_setvar_helper(chan, "PLAYBACKSTATUS", "FAILED");
-		else
-			pbx_builtin_setvar_helper(chan, "PLAYBACKSTATUS", "SUCCESS");
 	}
+	if (mres)
+		pbx_builtin_setvar_helper(chan, "PLAYBACKSTATUS", "FAILED");
+	else
+		pbx_builtin_setvar_helper(chan, "PLAYBACKSTATUS", "SUCCESS");
 	LOCAL_USER_REMOVE(u);
 	return res;
 }
diff --git a/pbx.c b/pbx.c
index cfa93195ef..f48e6b27a6 100644
--- a/pbx.c
+++ b/pbx.c
@@ -5745,7 +5745,7 @@ static int pbx_builtin_background(struct ast_channel *chan, void *data)
 			break;
 		default:
 			ast_log(LOG_WARNING, "Background requires an argument (filename)\n");
-			break;
+			return -1;
 		}
 	}