From: Fred Morcos <fred.morcos@open-xchange.com>
Date: Fri, 27 Oct 2023 10:08:27 +0000 (+0200)
Subject: Cleanup UeberBackend::getDomainInfo
X-Git-Tag: rec-5.0.0-beta1~16^2~25
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e255cb4bcaa580a97ebf70c5093c877af47c0853;p=thirdparty%2Fpdns.git

Cleanup UeberBackend::getDomainInfo
---

diff --git a/pdns/ueberbackend.cc b/pdns/ueberbackend.cc
index a2afd0be72..dcfd4cef9c 100644
--- a/pdns/ueberbackend.cc
+++ b/pdns/ueberbackend.cc
@@ -120,11 +120,13 @@ void UeberBackend::go()
   d_cond.notify_all();
 }
 
-bool UeberBackend::getDomainInfo(const DNSName& domain, DomainInfo& di, bool getSerial)
+bool UeberBackend::getDomainInfo(const DNSName& domain, DomainInfo& domainInfo, bool getSerial)
 {
-  for (auto backend : backends)
-    if (backend->getDomainInfo(domain, di, getSerial))
+  for (auto* backend : backends) {
+    if (backend->getDomainInfo(domain, domainInfo, getSerial)) {
       return true;
+    }
+  }
   return false;
 }
 
diff --git a/pdns/ueberbackend.hh b/pdns/ueberbackend.hh
index a036409aa4..19b1001fbb 100644
--- a/pdns/ueberbackend.hh
+++ b/pdns/ueberbackend.hh
@@ -106,8 +106,8 @@ public:
 
   void getUnfreshSlaveInfos(vector<DomainInfo>* domains);
   void getUpdatedMasters(vector<DomainInfo>& domains, std::unordered_set<DNSName>& catalogs, CatalogHashMap& catalogHashes);
-  bool getDomainInfo(const DNSName& domain, DomainInfo& di, bool getSerial = true);
   bool createDomain(const DNSName& domain, const DomainInfo::DomainKind kind, const vector<ComboAddress>& masters, const string& account);
+  bool getDomainInfo(const DNSName& domain, DomainInfo& domainInfo, bool getSerial = true);
 
   bool doesDNSSEC();
   bool addDomainKey(const DNSName& name, const DNSBackend::KeyData& key, int64_t& id);