From: Volker Lendecke <vl@samba.org>
Date: Mon, 5 Dec 2022 10:51:28 +0000 (+0100)
Subject: smbd: Remove a pointless NULL check from readlink_talloc()
X-Git-Tag: talloc-2.4.0~224
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e2ccd822037ac14cdedd971fde3a315922c0d135;p=thirdparty%2Fsamba.git

smbd: Remove a pointless NULL check from readlink_talloc()

We should never call this without the place to put the target in.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source3/smbd/files.c b/source3/smbd/files.c
index 8aa09680d54..87684b1984d 100644
--- a/source3/smbd/files.c
+++ b/source3/smbd/files.c
@@ -693,10 +693,6 @@ NTSTATUS readlink_talloc(
 	char *substitute;
 	NTSTATUS status;
 
-	if (_substitute == NULL) {
-		return NT_STATUS_OK;
-	}
-
 	if (smb_relname == NULL) {
 		/*
 		 * We have a Linux O_PATH handle in dirfsp and want to