From: Tim Beale Date: Thu, 1 Nov 2018 03:43:58 +0000 (+1300) Subject: selftest: Remove unnecessary code for backup testenvs X-Git-Tag: tdb-1.3.17~990 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e2ee595202fb338e3ecc9bd8c37e1b89d33d091f;p=thirdparty%2Fsamba.git selftest: Remove unnecessary code for backup testenvs setup_namespaces() already gets done for the backupfromdc's domain, so this step is unnecessary for the restoredc and offlinebackupdc testenvs (which are based off the backupfromdc's database). The setup_namespaces() step is still necessary for the renamedc/labdc, as these don't have the UPN/SPN suffixes for the new realm yet. Signed-off-by: Tim Beale Reviewed-by: Andrew Bartlett Autobuild-User(master): Andrew Bartlett Autobuild-Date(master): Thu Nov 1 13:06:01 CET 2018 on sn-devel-144 --- diff --git a/selftest/target/Samba4.pm b/selftest/target/Samba4.pm index 89704c2686e..41e550b51c0 100755 --- a/selftest/target/Samba4.pm +++ b/selftest/target/Samba4.pm @@ -2843,11 +2843,6 @@ sub setup_restoredc return undef; } - my $upn_array = ["$env->{REALM}.upn"]; - my $spn_array = ["$env->{REALM}.spn"]; - - $self->setup_namespaces($env, $upn_array, $spn_array); - return $env; } @@ -2939,11 +2934,6 @@ sub setup_offlinebackupdc return undef; } - my $upn_array = ["$env->{REALM}.upn"]; - my $spn_array = ["$env->{REALM}.spn"]; - - $self->setup_namespaces($env, $upn_array, $spn_array); - return $env; }