From: Vincent Bernat <vincent@bernat.im>
Date: Fri, 8 Apr 2016 20:17:44 +0000 (+0200)
Subject: BUG/MINOR: dns: fix DNS header definition
X-Git-Tag: v1.7-dev3~4
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e2f84977165a;p=thirdparty%2Fhaproxy.git

BUG/MINOR: dns: fix DNS header definition

Conforming to RFC 2535, section 6.1. This is not an important bug as
those fields don't seem to be set to something else than 0 and to be
checked on answers.
---

diff --git a/include/types/dns.h b/include/types/dns.h
index 757eaaf28d..98adc983bf 100644
--- a/include/types/dns.h
+++ b/include/types/dns.h
@@ -63,16 +63,16 @@
 /* DNS request or response header structure */
 struct dns_header {
 	unsigned short	id:16;		/* identifier */
-	unsigned char	rd :1;		/* recursion desired 0: no, 1: yes */
-	unsigned char	tc :1;		/* truncation 0:no, 1: yes */
-	unsigned char	aa :1;		/* authoritative answer 0: no, 1: yes */
-	unsigned char	opcode :4;	/* operation code */
 	unsigned char	qr :1;		/* query/response 0: query, 1: response */
-	unsigned char	rcode :4;	/* response code */
-	unsigned char	z :1;		/* no used */
+	unsigned char	opcode :4;	/* operation code */
+	unsigned char	aa :1;		/* authoritative answer 0: no, 1: yes */
+	unsigned char	tc :1;		/* truncation 0:no, 1: yes */
+	unsigned char	rd :1;		/* recursion desired 0: no, 1: yes */
+	unsigned char	ra :1;		/* recursion available 0: no, 1: yes */
+	unsigned char	z :1;		/* not used */
 	unsigned char	ad :1;		/* authentic data */
 	unsigned char	cd :1;		/* checking disabled */
-	unsigned char	ra :1;		/* recursion available 0: no, 1: yes */
+	unsigned char	rcode :4;	/* response code */
 	unsigned short	qdcount :16;	/* question count */
 	unsigned short	ancount :16;	/* answer count */
 	unsigned short	nscount :16;	/* authority count */