From: Dave Chinner Date: Mon, 10 Oct 2011 01:08:32 +0000 (+0000) Subject: repair: fix a valgrind reported error on i686 X-Git-Tag: v3.1.6~6 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e33b06a38d25afc791a115efa1b70a6c41e23329;p=thirdparty%2Fxfsprogs-dev.git repair: fix a valgrind reported error on i686 Fix a potential prefetch read problem due to the first loop execution of pf_batch_read potentially not initialising the fsbno variable: ==10177== Thread 6: ==10177== Conditional jump or move depends on uninitialised value(s) ==10177== at 0x8079CAB: pf_batch_read (prefetch.c:408) ==10177== by 0x6A2996D: clone (clone.S:130) ==10177== Signed-off-by: Dave Chinner Reviewed-by: Christoph Hellwig Signed-off-by: Alex Elder --- diff --git a/repair/prefetch.c b/repair/prefetch.c index d2fdf90aa..da074a89c 100644 --- a/repair/prefetch.c +++ b/repair/prefetch.c @@ -397,7 +397,7 @@ pf_batch_read( int len, size; int i; int inode_bufs; - unsigned long fsbno; + unsigned long fsbno = 0; unsigned long max_fsbno; char *pbuf;