From: Peter Krempa <pkrempa@redhat.com>
Date: Tue, 3 Nov 2020 11:00:21 +0000 (+0100)
Subject: qemu: backup: Use VIR_ERR_CHECKPOINT_INCONSISTENT when starting a backup
X-Git-Tag: v6.10.0-rc1~290
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e33e89d8399042f55fa6999fdfaa40ee884a9bfe;p=thirdparty%2Flibvirt.git

qemu: backup: Use VIR_ERR_CHECKPOINT_INCONSISTENT when starting a backup

If we don't have a consistent chain of bitmaps for the backup to proceed
we'd report VIR_ERR_INVALID_ARG error code, which makes it hard to
decide whether an incremental backup makes even sense.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/src/qemu/qemu_backup.c b/src/qemu/qemu_backup.c
index eb0682e193..2e3a2b2e3c 100644
--- a/src/qemu/qemu_backup.c
+++ b/src/qemu/qemu_backup.c
@@ -206,7 +206,7 @@ qemuBackupDiskPrepareOneBitmaps(struct qemuBackupDiskData *dd,
     if (!qemuBlockBitmapChainIsValid(dd->domdisk->src,
                                      dd->backupdisk->incremental,
                                      blockNamedNodeData)) {
-        virReportError(VIR_ERR_INVALID_ARG,
+        virReportError(VIR_ERR_CHECKPOINT_INCONSISTENT,
                        _("missing or broken bitmap '%s' for disk '%s'"),
                        dd->backupdisk->incremental, dd->domdisk->dst);
         return -1;