From: Timo Sirainen <tss@iki.fi>
Date: Mon, 12 May 2003 06:04:04 +0000 (+0300)
Subject: Don't check errno of getpwnam() and getspnam() functions. They don't seem to
X-Git-Tag: 1.1.alpha1~4646
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e3507728aced8c5d570962c00189aac27e6e1f20;p=thirdparty%2Fdovecot%2Fcore.git

Don't check errno of getpwnam() and getspnam() functions. They don't seem to
be set correctly in all systems and it's unlikely the error is anything else
than "user doesn't exist".

--HG--
branch : HEAD
---

diff --git a/src/auth/passdb-passwd.c b/src/auth/passdb-passwd.c
index 34350e8b83..3d2b7bfd5d 100644
--- a/src/auth/passdb-passwd.c
+++ b/src/auth/passdb-passwd.c
@@ -21,9 +21,7 @@ passwd_verify_plain(struct auth_request *request, const char *password,
 
 	pw = getpwnam(request->user);
 	if (pw == NULL) {
-		if (errno != 0)
-			i_error("getpwnam(%s) failed: %m", request->user);
-		else if (verbose)
+		if (verbose)
 			i_info("passwd(%s): unknown user", request->user);
 		callback(PASSDB_RESULT_USER_UNKNOWN, request);
 		return;
diff --git a/src/auth/passdb-shadow.c b/src/auth/passdb-shadow.c
index d94e9f7968..ee473f361a 100644
--- a/src/auth/passdb-shadow.c
+++ b/src/auth/passdb-shadow.c
@@ -21,9 +21,7 @@ shadow_verify_plain(struct auth_request *request, const char *password,
 
 	spw = getspnam(request->user);
 	if (spw == NULL) {
-		if (errno != 0)
-			i_error("getspnam(%s) failed: %m", request->user);
-		else if (verbose)
+		if (verbose)
 			i_info("shadow(%s): unknown user", request->user);
 		callback(PASSDB_RESULT_USER_UNKNOWN, request);
 		return;
diff --git a/src/auth/userdb-passwd.c b/src/auth/userdb-passwd.c
index 601463d202..901d9b8d59 100644
--- a/src/auth/userdb-passwd.c
+++ b/src/auth/userdb-passwd.c
@@ -18,9 +18,7 @@ static void passwd_lookup(const char *user, userdb_callback_t *callback,
 
 	pw = getpwnam(user);
 	if (pw == NULL) {
-		if (errno != 0)
-			i_error("getpwnam(%s) failed: %m", user);
-		else if (verbose)
+		if (verbose)
 			i_info("passwd(%s): unknown user", user);
 		callback(NULL, context);
 		return;