From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Mon, 11 Jan 2021 10:04:38 +0000 (+0100)
Subject: dnsdist: Fix uninitialized dnsheader in the rings unit tests
X-Git-Tag: rec-4.5.0-alpha1~19^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e3542673b3f3942c9c4489e11930e983e1ec8eb3;p=thirdparty%2Fpdns.git

dnsdist: Fix uninitialized dnsheader in the rings unit tests
---

diff --git a/pdns/dnsdistdist/test-dnsdistrings_cc.cc b/pdns/dnsdistdist/test-dnsdistrings_cc.cc
index 1213377f01..09181c221f 100644
--- a/pdns/dnsdistdist/test-dnsdistrings_cc.cc
+++ b/pdns/dnsdistdist/test-dnsdistrings_cc.cc
@@ -24,6 +24,7 @@ static void test_ring(size_t maxEntries, size_t numberOfShards, size_t nbLockTri
   }
 
   dnsheader dh;
+  memset(&dh, 0, sizeof(dh));
   DNSName qname("rings.powerdns.com.");
   ComboAddress requestor1("192.0.2.1");
   ComboAddress requestor2("192.0.2.2");
@@ -163,7 +164,7 @@ static void ringReaderThread(Rings& rings, std::atomic<bool>& done, size_t numbe
 #endif
 }
 
-static void ringWriterThread(Rings& rings, size_t numberOfEntries, const Rings::Query query, const Rings::Response response)
+static void ringWriterThread(Rings& rings, size_t numberOfEntries, const Rings::Query& query, const Rings::Response& response)
 {
   for (size_t idx = 0; idx < numberOfEntries; idx++) {
     rings.insertQuery(query.when, query.requestor, query.name, query.qtype, query.size, query.dh);
@@ -181,6 +182,7 @@ BOOST_AUTO_TEST_CASE(test_Rings_Threaded) {
   struct timespec now;
   gettime(&now);
   dnsheader dh;
+  memset(&dh, 0, sizeof(dh));
   dh.id = htons(4242);
   dh.qr = 0;
   dh.tc = 0;