From: Pieter Lexis <pieter.lexis@powerdns.com>
Date: Mon, 29 Sep 2025 12:21:22 +0000 (+0200)
Subject: fix: correct name for ProtoZero::Message::setOpenTelemetryTraceID
X-Git-Tag: rec-5.4.0-alpha1~187^2~18
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e373dac931539e3fbe28cf0d7c9cb299faf81266;p=thirdparty%2Fpdns.git

fix: correct name for ProtoZero::Message::setOpenTelemetryTraceID
---

diff --git a/pdns/dnsdistdist/dnsdist-protobuf.cc b/pdns/dnsdistdist/dnsdist-protobuf.cc
index 10774465c2..785463a052 100644
--- a/pdns/dnsdistdist/dnsdist-protobuf.cc
+++ b/pdns/dnsdistdist/dnsdist-protobuf.cc
@@ -245,7 +245,7 @@ void DNSDistProtoBufMessage::serialize(std::string& data) const
   }
 
   if (d_dq.ids.tracingEnabled) {
-    msg.setOpenTelemtryTraceID(d_dq.ids.d_OTTracer->getTraceID());
+    msg.setOpenTelemetryTraceID(d_dq.ids.d_OTTracer->getTraceID());
     msg.setOpenTelemetryData(d_dq.ids.d_OTTracer->getOTProtobuf());
   }
 }
diff --git a/pdns/protozero.hh b/pdns/protozero.hh
index 744e3bcb93..c33b0a3ce6 100644
--- a/pdns/protozero.hh
+++ b/pdns/protozero.hh
@@ -337,7 +337,7 @@ namespace ProtoZero
       }
     }
 
-    void setOpenTelemtryTraceID(const std::array<uint8_t, 16>& traceID)
+    void setOpenTelemetryTraceID(const std::array<uint8_t, 16>& traceID)
     {
       add_bytes(d_message, Field::openTelemetryTraceID, reinterpret_cast<const char*>(traceID.data()), traceID.size()); // NOLINT(cppcoreguidelines-pro-type-reinterpret-cast): it's the API
     }
diff --git a/pdns/recursordist/pdns_recursor.cc b/pdns/recursordist/pdns_recursor.cc
index dab277280e..7dab4fae43 100644
--- a/pdns/recursordist/pdns_recursor.cc
+++ b/pdns/recursordist/pdns_recursor.cc
@@ -1867,7 +1867,7 @@ void startDoResolve(void* arg) // NOLINT(readability-function-cognitive-complexi
       }
       // Currently only set if an OT trace is generated
       if (resolver.d_otTrace.trace_id != pdns::trace::s_emptyTraceID) {
-        pbMessage.setOpenTelemtryTraceID(resolver.d_otTrace.trace_id);
+        pbMessage.setOpenTelemetryTraceID(resolver.d_otTrace.trace_id);
       }
       if (comboWriter->d_logResponse) {
         protobufLogResponse(pbMessage);
diff --git a/pdns/recursordist/rec-main.cc b/pdns/recursordist/rec-main.cc
index dcf32ef8d8..365a1d13f3 100644
--- a/pdns/recursordist/rec-main.cc
+++ b/pdns/recursordist/rec-main.cc
@@ -544,7 +544,7 @@ void protobufLogQuery(LocalStateHolder<LuaConfigItems>& luaconfsLocal, const boo
     msg.setEDNSVersion(*ednsVersion);
   }
   if (traceID != pdns::trace::s_emptyTraceID) {
-    msg.setOpenTelemtryTraceID(traceID);
+    msg.setOpenTelemetryTraceID(traceID);
   }
 
   std::string strMsg(msg.finishAndMoveBuf());
@@ -640,7 +640,7 @@ void protobufLogResponse(const DNSName& qname, QType qtype,
     pbMessage.setOpenTelemetryData(trace.encode());
   }
   if (otTrace.trace_id != pdns::trace::s_emptyTraceID) {
-    pbMessage.setOpenTelemtryTraceID(otTrace.trace_id);
+    pbMessage.setOpenTelemetryTraceID(otTrace.trace_id);
   }
   pbMessage.addPolicyTags(policyTags);