From: Tomek Mrugalski <tomasz@isc.org>
Date: Thu, 11 Jan 2018 14:43:59 +0000 (+0100)
Subject: [master] Merge branch 'github37' (Cassandra host reservations)
X-Git-Tag: trac5425a_base~11
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e37606fd2d0c02234a55f7445c52a12b2e7a82ec;p=thirdparty%2Fkea.git

[master] Merge branch 'github37' (Cassandra host reservations)

# Conflicts:
#	src/lib/dhcpsrv/tests/generic_host_data_source_unittest.cc
---

e37606fd2d0c02234a55f7445c52a12b2e7a82ec
diff --cc src/lib/dhcpsrv/tests/generic_host_data_source_unittest.cc
index bdf606652f,52ffe3a588..adcec08d21
--- a/src/lib/dhcpsrv/tests/generic_host_data_source_unittest.cc
+++ b/src/lib/dhcpsrv/tests/generic_host_data_source_unittest.cc
@@@ -381,24 -399,13 +410,26 @@@ GenericHostDataSourceTest::compareOptio
              OptionDescriptor desc2 = cfg2->get(space, desc1.option_->getType());
              // Compare persistent flag.
              EXPECT_EQ(desc1.persistent_, desc2.persistent_)
-                 << "failed for option " << space << "." << desc1.option_->getType();
+                 << "failed for option " << space << "."
+                 << desc1.option_->getType();
              // Compare formatted value.
              EXPECT_EQ(desc1.formatted_value_, desc2.formatted_value_)
-                 << "failed for option " << space << "." << desc1.option_->getType();
+                 << "failed for option " << space << "."
+                 << desc1.option_->getType();
  
 +            // Compare user context.
 +            ConstElementPtr ctx1 = desc1.getContext();
 +            ConstElementPtr ctx2 = desc2.getContext();
 +            if (ctx1) {
 +                EXPECT_TRUE(ctx2);
 +                if (ctx2) {
 +                    EXPECT_EQ(*ctx1, *ctx2)
 +                        << "failed for option " << space << "." << desc1.option_->getType();
 +                }
 +            } else {
 +                EXPECT_FALSE(ctx2);
 +            }
 +
              // Retrieve options.
              Option* option1 = desc1.option_.get();
              Option* option2 = desc2.option_.get();
@@@ -1247,15 -1213,15 +1281,15 @@@ GenericHostDataSourceTest::testMultiple
      host2->addReservation(resv1);
  
      // Check if reservations are the same
-     compareReservations6(host1->getIPv6Reservations(), host2->getIPv6Reservations());
- 
+     compareReservations6(host1->getIPv6Reservations(),
+                          host2->getIPv6Reservations());
  }
  
 -void
 -GenericHostDataSourceTest::testOptionsReservations4(const bool formatted) {
 +void GenericHostDataSourceTest::testOptionsReservations4(const bool formatted,
 +                                                         ConstElementPtr user_context) {
      HostPtr host = initializeHost4("192.0.2.5", Host::IDENT_HWADDR);
      // Add a bunch of DHCPv4 and DHCPv6 options for the host.
 -    ASSERT_NO_THROW(addTestOptions(host, formatted, DHCP4_ONLY));
 +    ASSERT_NO_THROW(addTestOptions(host, formatted, DHCP4_ONLY, user_context));
      // Insert host and the options into respective tables.
      ASSERT_NO_THROW(hdsptr_->add(host));
      // Subnet id will be used in queries to the database.
diff --cc src/share/database/scripts/mysql/Makefile.am
index cf2e4b2eaa,d5eb5d474a..cfc8134d96
--- a/src/share/database/scripts/mysql/Makefile.am
+++ b/src/share/database/scripts/mysql/Makefile.am
@@@ -9,9 -9,7 +9,8 @@@ sqlscripts_DATA += upgrade_3.0_to_4.0.s
  sqlscripts_DATA += upgrade_4.0_to_4.1.sh
  sqlscripts_DATA += upgrade_4.1_to_5.0.sh
  sqlscripts_DATA += upgrade_5.0_to_5.1.sh
 +sqlscripts_DATA += upgrade_5.1_to_6.0.sh
  
- 
  DISTCLEANFILES = upgrade_1.0_to_2.0.sh
  DISTCLEANFILES += upgrade_2.0_to_3.0.sh
  DISTCLEANFILES += upgrade_3.0_to_4.0.sh