From: Stefan Metzmacher <metze@samba.org>
Date: Thu, 21 Jun 2018 17:20:53 +0000 (+0200)
Subject: smbd: avoid explicit change_to_user() in defer_rename_done() already done by imperson... 
X-Git-Tag: ldb-1.5.0~340
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e37e41b3cac52e3623f0c79f83733a51edb35c10;p=thirdparty%2Fsamba.git

smbd: avoid explicit change_to_user() in defer_rename_done() already done by impersonation

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
---

diff --git a/source3/smbd/smb2_setinfo.c b/source3/smbd/smb2_setinfo.c
index 5a6a28a323e..1f07b7e1190 100644
--- a/source3/smbd/smb2_setinfo.c
+++ b/source3/smbd/smb2_setinfo.c
@@ -281,7 +281,6 @@ static void defer_rename_done(struct tevent_req *subreq)
 	NTSTATUS status;
 	struct share_mode_lock *lck;
 	int ret_size = 0;
-	bool ok;
 
 	status = dbwrap_watched_watch_recv(subreq, NULL, NULL);
 	TALLOC_FREE(subreq);
@@ -292,16 +291,6 @@ static void defer_rename_done(struct tevent_req *subreq)
 		return;
 	}
 
-	/*
-	 * Make sure we run as the user again
-	 */
-	ok = change_to_user(state->smb2req->tcon->compat,
-			    state->smb2req->session->compat->vuid);
-	if (!ok) {
-		tevent_req_nterror(state->req, NT_STATUS_ACCESS_DENIED);
-		return;
-	}
-
 	/* Do we still need to wait ? */
 	lck = get_existing_share_mode_lock(state->req, state->fsp->file_id);
 	if (lck == NULL) {