From: Jeremy Allison <jra@samba.org>
Date: Fri, 22 May 2009 22:21:55 +0000 (-0700)
Subject: Test that POSIX open of a directory returns NT_STATUS_FILE_IS_A_DIRECTORY (ERRDOS... 
X-Git-Tag: tdb-1.1.5~420
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e3851a9110dfb416c74bc979a0dedc074883067f;p=thirdparty%2Fsamba.git

Test that POSIX open of a directory returns NT_STATUS_FILE_IS_A_DIRECTORY (ERRDOS, EISDIR).
Jeremy.
---

diff --git a/source3/torture/torture.c b/source3/torture/torture.c
index 66512190986..20561a7eda1 100644
--- a/source3/torture/torture.c
+++ b/source3/torture/torture.c
@@ -4211,6 +4211,17 @@ static bool run_simple_posix_open_test(int dummy)
 		goto out;
 	}
 
+	/* What happens when we try and POSIX open a directory ? */
+	if (NT_STATUS_IS_OK(cli_posix_open(cli1, dname, O_RDONLY, 0, &fnum1))) {
+		printf("POSIX open of directory %s succeeded, should have failed.\n", fname);
+		goto out;
+	} else {
+		if (!check_error(__LINE__, cli1, ERRDOS, EISDIR,
+				NT_STATUS_FILE_IS_A_DIRECTORY)) {
+			goto out;
+		}
+	}
+
 	if (!NT_STATUS_IS_OK(cli_posix_rmdir(cli1, dname))) {
 		printf("POSIX rmdir failed (%s)\n", cli_errstr(cli1));
 		goto out;
@@ -4223,7 +4234,7 @@ static bool run_simple_posix_open_test(int dummy)
 
 	if (fnum1 != (uint16_t)-1) {
 		cli_close(cli1, fnum1);
-		fnum1 = -1;
+		fnum1 = (uint16_t)-1;
 	}
 
 	cli_setatr(cli1, fname, 0, 0);