From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Mon, 4 Mar 2024 11:26:39 +0000 (+0100)
Subject: dnsdist: Delint dnsdist-dnscrypt.cc
X-Git-Tag: dnsdist-1.10.0-alpha0~8^2~21
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e396e3b12645f84d3ab716dfa6f34db6dc2e2424;p=thirdparty%2Fpdns.git

dnsdist: Delint dnsdist-dnscrypt.cc
---

diff --git a/pdns/dnsdistdist/dnsdist-dnscrypt.cc b/pdns/dnsdistdist/dnsdist-dnscrypt.cc
index 8f02910aaa..a7a776cba7 100644
--- a/pdns/dnsdistdist/dnsdist-dnscrypt.cc
+++ b/pdns/dnsdistdist/dnsdist-dnscrypt.cc
@@ -25,16 +25,16 @@
 #include "dnscrypt.hh"
 
 #ifdef HAVE_DNSCRYPT
-int handleDNSCryptQuery(PacketBuffer& packet, DNSCryptQuery& query, bool tcp, time_t now, PacketBuffer& response)
+bool handleDNSCryptQuery(PacketBuffer& packet, DNSCryptQuery& query, bool tcp, time_t now, PacketBuffer& response)
 {
   query.parsePacket(packet, tcp, now);
 
-  if (query.isValid() == false) {
+  if (!query.isValid()) {
     vinfolog("Dropping DNSCrypt invalid query");
     return false;
   }
 
-  if (query.isEncrypted() == false) {
+  if (!query.isEncrypted()) {
     query.getCertificateResponse(now, response);
 
     return false;
diff --git a/pdns/dnsdistdist/dnsdist.hh b/pdns/dnsdistdist/dnsdist.hh
index 9db31de62f..e345614be5 100644
--- a/pdns/dnsdistdist/dnsdist.hh
+++ b/pdns/dnsdistdist/dnsdist.hh
@@ -1241,7 +1241,7 @@ bool responseContentMatches(const PacketBuffer& response, const DNSName& qname,
 bool checkQueryHeaders(const struct dnsheader& dnsHeader, ClientState& clientState);
 
 extern std::vector<std::shared_ptr<DNSCryptContext>> g_dnsCryptLocals;
-int handleDNSCryptQuery(PacketBuffer& packet, DNSCryptQuery& query, bool tcp, time_t now, PacketBuffer& response);
+bool handleDNSCryptQuery(PacketBuffer& packet, DNSCryptQuery& query, bool tcp, time_t now, PacketBuffer& response);
 bool checkDNSCryptQuery(const ClientState& cs, PacketBuffer& query, std::unique_ptr<DNSCryptQuery>& dnsCryptQuery, time_t now, bool tcp);
 
 #include "dnsdist-snmp.hh"