From: teor (Tim Wilson-Brown) <teor2345@gmail.com>
Date: Sun, 31 Jan 2016 23:07:19 +0000 (+1100)
Subject: Replace incorrect use of snprintf in unit tests with tor_snprintf
X-Git-Tag: tor-0.2.8.1-alpha~26^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e3da5ad6e3bcee7cb9b639296e186fbeda5a6d9c;p=thirdparty%2Ftor.git

Replace incorrect use of snprintf in unit tests with tor_snprintf

This avoids a potential out of bounds write.
---

diff --git a/src/test/test_tortls.c b/src/test/test_tortls.c
index cbbd7dd3f3..98f5facc11 100644
--- a/src/test/test_tortls.c
+++ b/src/test/test_tortls.c
@@ -1808,9 +1808,10 @@ test_tortls_debug_state_callback(void *ignored)
 
   tor_tls_debug_state_callback(ssl, 32, 45);
 
-  n = snprintf(buf, 1000, "SSL %p is now in state unknown"
+  n = tor_snprintf(buf, 1000, "SSL %p is now in state unknown"
                " state [type=32,val=45].\n", ssl);
-  buf[n]='\0';
+  /* tor's snprintf returns -1 on error */
+  tt_int_op(n, OP_NE, -1);
   expect_log_msg(buf);
 
  done: