From: mkanat%bugzilla.org <>
Date: Sun, 13 Dec 2009 21:59:41 +0000 (+0000)
Subject: The tinderbox was burning from the checkin of the
X-Git-Tag: bugzilla-3.5.3~52
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e401b0b8b925787cbe52d0f540b814e40269f228;p=thirdparty%2Fbugzilla.git

The tinderbox was burning from the checkin of the
"webservice attachments by ids" patch--it looks like a part of the patch
was just missing or something when it was posted to bmo. I've fixed it now.
---

diff --git a/Bugzilla/WebService/Bug.pm b/Bugzilla/WebService/Bug.pm
index 9eb3573516..75c6d76b53 100644
--- a/Bugzilla/WebService/Bug.pm
+++ b/Bugzilla/WebService/Bug.pm
@@ -413,11 +413,8 @@ sub update_see_also {
 sub attachments {
     my ($self, $params) = validate(@_, 'ids', 'attachment_ids');
 
-    my $ids = $params->{ids};
-    defined $ids || ThrowCodeError('param_required', { param => 'ids' });
-
     if (!(defined $params->{ids}
-          || defined $params->{attachment_ids}))
+          or defined $params->{attachment_ids}))
     {
         ThrowCodeError('param_required',
                        { function => 'Bug.attachments',