From: Max Kanat-Alexander <mkanat@bugzilla.org>
Date: Sat, 27 Feb 2010 07:51:20 +0000 (-0800)
Subject: Bug 547601: Make the JSON-RPC interface return UTF-8 data correctly
X-Git-Tag: bugzilla-3.6rc1~23
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e4118628503d9ae25f3facdf14f6ae78e432bfeb;p=thirdparty%2Fbugzilla.git

Bug 547601: Make the JSON-RPC interface return UTF-8 data correctly
r=dkl, a=mkanat
---

diff --git a/Bugzilla/WebService/Server/JSONRPC.pm b/Bugzilla/WebService/Server/JSONRPC.pm
index cc3e8058ec..35eda1af1d 100644
--- a/Bugzilla/WebService/Server/JSONRPC.pm
+++ b/Bugzilla/WebService/Server/JSONRPC.pm
@@ -35,13 +35,23 @@ sub new {
     Bugzilla->_json_server($self);
     $self->dispatch(WS_DISPATCH);
     $self->return_die_message(1);
-    $self->json->allow_blessed(1);
-    $self->json->convert_blessed(1);
     # Default to JSON-RPC 1.0
     $self->version(0);
     return $self;
 }
 
+sub create_json_coder {
+    my $self = shift;
+    my $json = $self->SUPER::create_json_coder(@_);
+    $json->allow_blessed(1);
+    $json->convert_blessed(1);
+    # This may seem a little backwards, but what this really means is
+    # "don't convert our utf8 into byte strings, just leave it as a
+    # utf8 string."
+    $json->utf8(0) if Bugzilla->params->{'utf8'};
+    return $json;
+}
+
 # Override the JSON::RPC method to return our CGI object instead of theirs.
 sub cgi { return Bugzilla->cgi; }