From: Štěpán Balážik <stepan@isc.org>
Date: Fri, 10 Apr 2026 16:25:17 +0000 (+0200)
Subject: Improve readability of endianness conversions
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e43fa1dc5ad3cecd5b762b0bd8d4156e1c48595b;p=thirdparty%2Fbind9.git

Improve readability of endianness conversions

Replace the less obvious and less explicit `struct.unpack()` and
`struct.pack()` calls with calls to `int.from_bytes()` and
`int.to_bytes()`, respectively.
---

diff --git a/bin/tests/system/isctest/asyncserver.py b/bin/tests/system/isctest/asyncserver.py
index e29d6f7e9a0..53cdfeb47c1 100644
--- a/bin/tests/system/isctest/asyncserver.py
+++ b/bin/tests/system/isctest/asyncserver.py
@@ -26,7 +26,6 @@ import os
 import pathlib
 import re
 import signal
-import struct
 import sys
 
 import dns.exception
@@ -1273,9 +1272,7 @@ class AsyncDnsServer(AsyncServer):
         if not wire_length_bytes:
             return None
 
-        (wire_length,) = struct.unpack("!H", wire_length_bytes)
-
-        return wire_length
+        return int.from_bytes(wire_length_bytes, byteorder="big")
 
     async def _read_tcp_query_wire(
         self, reader: asyncio.StreamReader, peer: Peer, wire_length: int
@@ -1416,8 +1413,7 @@ class AsyncDnsServer(AsyncServer):
                 if protocol == DnsProtocol.UDP:
                     yield response
                 else:
-                    response_length = struct.pack("!H", len(response))
-                    yield response_length + response
+                    yield len(payload).to_bytes(2, byteorder="big") + payload
 
     def _parse_message(self, wire: bytes) -> dns.message.Message:
         try: