From: Ján Tomko <jtomko@redhat.com>
Date: Wed, 6 Nov 2024 13:03:27 +0000 (+0100)
Subject: ch: check return value of virJSONValueArrayAppend
X-Git-Tag: v10.10.0-rc1~187
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e45313c031574814c392539e57993a02289ac6b3;p=thirdparty%2Flibvirt.git

ch: check return value of virJSONValueArrayAppend

It only errors out when presented with a non-array, but we do check
it everywhere else.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
---

diff --git a/src/ch/ch_monitor.c b/src/ch/ch_monitor.c
index 3e49902791..ccd04cfbd1 100644
--- a/src/ch/ch_monitor.c
+++ b/src/ch/ch_monitor.c
@@ -1002,7 +1002,8 @@ virCHMonitorBuildRestoreJson(virDomainDef *vmdef,
                 return -1;
             if (virJSONValueObjectAppendNumberInt(net_json, "num_fds", vmdef->nets[i]->driver.virtio.queues))
                 return -1;
-            virJSONValueArrayAppend(nets, &net_json);
+            if (virJSONValueArrayAppend(nets, &net_json) < 0)
+                return -1;
         }
         if (virJSONValueObjectAppend(restore_json, "net_fds", &nets))
             return -1;