From: lpsolit%gmail.com <>
Date: Sun, 20 Jan 2008 08:45:31 +0000 (+0000)
Subject: Bug 143313: check_can_change_field() is no longer called with --do_not_change-- as... 
X-Git-Tag: bugzilla-3.1.3~375
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e49a811b3d40b3defc995d98a58ce3c593c00186;p=thirdparty%2Fbugzilla.git

Bug 143313: check_can_change_field() is no longer called with --do_not_change-- as field value - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=mkanat
---

diff --git a/Bugzilla/Bug.pm b/Bugzilla/Bug.pm
index 9f44332630..722914c5f4 100755
--- a/Bugzilla/Bug.pm
+++ b/Bugzilla/Bug.pm
@@ -3211,11 +3211,10 @@ sub CheckIfVotedConfirmed {
 # $oldvalue - what they are changing it from
 # $newvalue - what they are changing it to
 # $PrivilegesRequired - return the reason of the failure, if any
-# $data     - hash containing relevant parameters, e.g. from the CGI object
 ################################################################################
 sub check_can_change_field {
     my $self = shift;
-    my ($field, $oldvalue, $newvalue, $PrivilegesRequired, $data) = (@_);
+    my ($field, $oldvalue, $newvalue, $PrivilegesRequired) = (@_);
     my $user = Bugzilla->user;
 
     $oldvalue = defined($oldvalue) ? $oldvalue : '';
@@ -3231,7 +3230,6 @@ sub check_can_change_field {
         return 1;
     # numeric fields need to be compared using ==
     } elsif (($field eq 'estimated_time' || $field eq 'remaining_time')
-             && (!$data || $newvalue ne $data->{'dontchange'})
              && $oldvalue == $newvalue)
     {
         return 1;