From: Jeremy Allison <jra@samba.org>
Date: Mon, 25 Jan 2021 20:26:14 +0000 (-0800)
Subject: VFS: media_harmony: Fixup mh_symlinkat() to correctly use the dirfsp path.
X-Git-Tag: tevent-0.11.0~1953
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e4a3633694ba1b61fa21ca0cc3174c8a3981bdb7;p=thirdparty%2Fsamba.git

VFS: media_harmony: Fixup mh_symlinkat() to correctly use the dirfsp path.

Missed in my original fixes.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
---

diff --git a/source3/modules/vfs_media_harmony.c b/source3/modules/vfs_media_harmony.c
index 40eb81c677b..ecf8b49ccf3 100644
--- a/source3/modules/vfs_media_harmony.c
+++ b/source3/modules/vfs_media_harmony.c
@@ -1613,12 +1613,22 @@ static int mh_symlinkat(vfs_handle_struct *handle,
 		const struct smb_filename *new_smb_fname)
 {
 	int status = -1;
+	struct smb_filename *full_fname = NULL;
 	struct smb_filename *new_link_target = NULL;
 	struct smb_filename *newclientFname = NULL;
 
 	DEBUG(MH_INFO_DEBUG, ("Entering mh_symlinkat\n"));
+
+	full_fname = full_path_from_dirfsp_atname(talloc_tos(),
+						dirfsp,
+						new_smb_fname);
+	if (full_fname == NULL) {
+		status = -1;
+		goto err;
+	}
+
 	if (!is_in_media_files(link_contents->base_name) &&
-			!is_in_media_files(new_smb_fname->base_name)) {
+			!is_in_media_files(full_fname->base_name)) {
 		status = SMB_VFS_NEXT_SYMLINKAT(handle,
 				link_contents,
 				dirfsp,
@@ -1632,19 +1642,20 @@ static int mh_symlinkat(vfs_handle_struct *handle,
 		goto err;
 	}
 	if ((status = alloc_get_client_smb_fname(handle, talloc_tos(),
-				new_smb_fname,
+				full_fname,
 				&newclientFname))) {
 		goto err;
 	}
 
 	status = SMB_VFS_NEXT_SYMLINKAT(handle,
 				new_link_target,
-				dirfsp,
+				handle->conn->cwd_fsp,
 				newclientFname);
 err:
 	TALLOC_FREE(new_link_target);
 	TALLOC_FREE(newclientFname);
 out:
+	TALLOC_FREE(full_fname);
 	return status;
 }