From: Jim Meyering <meyering@redhat.com>
Date: Wed, 2 Sep 2009 07:58:50 +0000 (+0200)
Subject: lxc: avoid NULL dereference upon getmntent failure
X-Git-Tag: v0.7.1~121
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e4ac19a87a5ca4fbdcc51780ca4b8866c1690baa;p=thirdparty%2Flibvirt.git

lxc: avoid NULL dereference upon getmntent failure

* src/lxc_container.c (lxcContainerUnmountOldFS): Don't pass
a NULL pointer to qsort.
---

diff --git a/src/lxc_container.c b/src/lxc_container.c
index 950dd50215..20738648a5 100644
--- a/src/lxc_container.c
+++ b/src/lxc_container.c
@@ -546,8 +546,9 @@ static int lxcContainerUnmountOldFS(void)
     }
     endmntent(procmnt);
 
-    qsort(mounts, nmounts, sizeof(mounts[0]),
-          lxcContainerChildMountSort);
+    if (mounts)
+        qsort(mounts, nmounts, sizeof(mounts[0]),
+              lxcContainerChildMountSort);
 
     for (i = 0 ; i < nmounts ; i++) {
         VIR_DEBUG("Umount %s", mounts[i]);