From: Josh Soref <2119212+jsoref@users.noreply.github.com>
Date: Mon, 17 Nov 2025 13:29:15 +0000 (-0500)
Subject: Mark `classmethod` PaddingOption.from_wire
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e4eaa4ae133cee73151288e83fb6128161a9c26d;p=thirdparty%2Fpdns.git

Mark `classmethod` PaddingOption.from_wire

Signed-off-by: Pieter Lexis <pieter.lexis@powerdns.com>
---

diff --git a/regression-tests.common/paddingoption.py b/regression-tests.common/paddingoption.py
index bb3382e1a1..a6983151ec 100644
--- a/regression-tests.common/paddingoption.py
+++ b/regression-tests.common/paddingoption.py
@@ -22,6 +22,7 @@ class PaddingOption(dns.edns.Option):
         file.write(bytes(self.numberOfBytes))
         return None
 
+    @classmethod
     def from_wire(cls, otype, wire, current, olen):
         """Read EDNS packet as defined in rfc7830.
 
@@ -33,8 +34,6 @@ class PaddingOption(dns.edns.Option):
 
         return cls(numberOfBytes)
 
-    from_wire = classmethod(from_wire)
-
     # needed in 2.0.0
     @classmethod
     def from_wire_parser(cls, otype, parser):
@@ -50,7 +49,7 @@ class PaddingOption(dns.edns.Option):
     def __eq__(self, other):
         if not isinstance(other, PaddingOption):
             return False
-        return self.numberOfBytes == numberOfBytes
+        return self.numberOfBytes == other.numberOfBytes
 
     def __ne__(self, other):
         return not self.__eq__(other)