From: Michael Schroeder <mls@suse.de>
Date: Thu, 20 Nov 2008 17:23:56 +0000 (+0000)
Subject: - get rid of unused pool argument in solvable_identical
X-Git-Tag: BASE-SuSE-Code-12_1-Branch~308^2~51
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e5073cac904abb14ddfe9a402158a10e2ffd702e;p=thirdparty%2Flibsolv.git

- get rid of unused pool argument in solvable_identical
---

diff --git a/src/pool.h b/src/pool.h
index 0aef9565..7e386661 100644
--- a/src/pool.h
+++ b/src/pool.h
@@ -193,7 +193,7 @@ int solvable_lookup_void(Solvable *s, Id keyname);
 char * solvable_get_location(Solvable *s, unsigned int *medianrp);
 const unsigned char *solvable_lookup_bin_checksum(Solvable *s, Id keyname, Id *typep);
 const char *solvable_lookup_checksum(Solvable *s, Id keyname, Id *typep);
-int solvable_identical(Pool *pool, Solvable *s1, Solvable *s2);
+int solvable_identical(Solvable *s1, Solvable *s2);
 
 int solvable_trivial_installable_map(Solvable *s, Map *installedmap, Map *conflictsmap);
 int solvable_trivial_installable_repo(Solvable *s, struct _Repo *installed);
diff --git a/src/solvable.c b/src/solvable.c
index 0174ee50..96e329bd 100644
--- a/src/solvable.c
+++ b/src/solvable.c
@@ -469,8 +469,11 @@ pool_create_state_maps(Pool *pool, Queue *installed, Map *installedmap, Map *con
     }
 }
 
+/* Tests if two solvables have identical content. Currently
+ * both solvables need to come from the same pool */
+
 int
-solvable_identical(Pool *pool, Solvable *s1, Solvable *s2)
+solvable_identical(Solvable *s1, Solvable *s2)
 {
   unsigned int bt1, bt2;
   Id rq1, rq2;
diff --git a/src/solver.c b/src/solver.c
index 923cb33f..41543830 100644
--- a/src/solver.c
+++ b/src/solver.c
@@ -1484,7 +1484,7 @@ finddistupgradepackages(Solver *solv, Solvable *s, Queue *qs, int allow_all)
   for (i = 0; i < qs->count; i++)
     {
       Solvable *ns = pool->solvables + qs->elements[i];
-      if (s->evr == ns->evr && solvable_identical(pool, s, ns))
+      if (s->evr == ns->evr && solvable_identical(s, ns))
         return s - pool->solvables;
     }
   /* nope, it must be some other package */