From: Grégory Oestreicher <greg@kamago.net>
Date: Wed, 12 Apr 2017 19:26:22 +0000 (+0200)
Subject: Only log when there's an actual error
X-Git-Tag: dnsdist-1.3.1~167^2~11
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e522dbee9f589148e1a3d562cc7261653512ab68;p=thirdparty%2Fpdns.git

Only log when there's an actual error
---

diff --git a/modules/ldapbackend/ldapauthenticator.cc b/modules/ldapbackend/ldapauthenticator.cc
index 12a43fd202..77577ad475 100644
--- a/modules/ldapbackend/ldapauthenticator.cc
+++ b/modules/ldapbackend/ldapauthenticator.cc
@@ -249,11 +249,13 @@ int LdapGssapiAuthenticator::updateTgt()
   krb5_free_principal( context, principal );
 
   if ( code == 0 ) {
-    g_log<<Logger::Error << logPrefix << "krb5 error when getting the TGT: " << std::string( krb5_get_error_message( context, code ) ) << std::endl;
     code = krb5_cc_store_cred( context, ccache, &credentials );
     krb5_free_cred_contents( context, &credentials );
     krb5_cc_close( context, ccache );
   }
+  else {
+    g_log<<Logger::Error << logPrefix << "krb5 error when getting the TGT: " << std::string( krb5_get_error_message( context, code ) ) << std::endl;
+  }
 
   krb5_free_context( context );
   return code;