From: Erik Skultety <eskultet@redhat.com>
Date: Sat, 14 May 2016 17:10:39 +0000 (+0200)
Subject: admin: Fix passing an incorrect readonly attribute to virNetServerServiceNew
X-Git-Tag: v1.3.5-rc1~211
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e54b81604d0169e559dee490e477a3d4867ccc5b;p=thirdparty%2Flibvirt.git

admin: Fix passing an incorrect readonly attribute to virNetServerServiceNew

When registering admin UNIX socket, a new service is created for it. This
service is incorrectly initialized to be readonly, which is later inherited by
all clients connected to the socket. In libvirt-admin's case there currently
isn't any use for the attribute anyway, but since the socket has root-only
access permissions, the least we can do is to make every admin client
connected to it report readonly as false.

Signed-off-by: Erik Skultety <eskultet@redhat.com>
---

diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c
index cc5190f096..f24fb22007 100644
--- a/daemon/libvirtd.c
+++ b/daemon/libvirtd.c
@@ -543,7 +543,7 @@ daemonSetupNetworking(virNetServerPtr srv,
 #if WITH_GNUTLS
                                                   NULL,
 #endif
-                                                  true,
+                                                  false,
                                                   config->admin_max_queued_clients,
                                                   config->admin_max_client_requests)))
             goto cleanup;