From: Niklas Cassel Date: Mon, 10 Mar 2025 11:10:22 +0000 (+0100) Subject: PCI: dw-rockchip: Endpoint mode cannot raise INTx interrupts X-Git-Tag: v6.15-rc1~119^2~18^2~2 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e55c67837a8cd42d6936e567f2ac75337b0e57f6;p=thirdparty%2Fkernel%2Flinux.git PCI: dw-rockchip: Endpoint mode cannot raise INTx interrupts Neither RK3568 or RK3588 supports INTx interrupts. Since epc_features is zero initialized, this is strictly not needed. However, setting intx_capable explicitly to false makes it more clear that neither RK3568 or RK3588 supports INTx interrupts. No functional change. Signed-off-by: Niklas Cassel Signed-off-by: Krzysztof Wilczyński Link: https://lore.kernel.org/r/20250310111016.859445-14-cassel@kernel.org --- diff --git a/drivers/pci/controller/dwc/pcie-dw-rockchip.c b/drivers/pci/controller/dwc/pcie-dw-rockchip.c index 93698abff4d9c..4aa25bcf91060 100644 --- a/drivers/pci/controller/dwc/pcie-dw-rockchip.c +++ b/drivers/pci/controller/dwc/pcie-dw-rockchip.c @@ -272,6 +272,7 @@ static const struct pci_epc_features rockchip_pcie_epc_features_rk3568 = { .linkup_notifier = true, .msi_capable = true, .msix_capable = true, + .intx_capable = false, .align = SZ_64K, .bar[BAR_0] = { .type = BAR_FIXED, .fixed_size = SZ_1M, }, .bar[BAR_1] = { .type = BAR_FIXED, .fixed_size = SZ_1M, }, @@ -292,6 +293,7 @@ static const struct pci_epc_features rockchip_pcie_epc_features_rk3588 = { .linkup_notifier = true, .msi_capable = true, .msix_capable = true, + .intx_capable = false, .align = SZ_64K, .bar[BAR_0] = { .type = BAR_FIXED, .fixed_size = SZ_1M, }, .bar[BAR_1] = { .type = BAR_FIXED, .fixed_size = SZ_1M, },