From: Timo Sirainen <timo.sirainen@open-xchange.com>
Date: Fri, 13 Jan 2023 01:21:23 +0000 (+0200)
Subject: lib-storage: Don't use HOME environment when userdb lookup is disabled
X-Git-Tag: 2.4.0~3116
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e57d5b9002f910c095ee5b55821395fcf1da016a;p=thirdparty%2Fdovecot%2Fcore.git

lib-storage: Don't use HOME environment when userdb lookup is disabled

We no longer support cli tools using settings from environment. This was
also causing problems in the following commits.
---

diff --git a/src/lib-storage/mail-storage-service.c b/src/lib-storage/mail-storage-service.c
index 35f5d5db41..855026e89c 100644
--- a/src/lib-storage/mail-storage-service.c
+++ b/src/lib-storage/mail-storage-service.c
@@ -1377,12 +1377,6 @@ mail_storage_service_lookup_real(struct mail_storage_service_ctx *ctx,
 	if ((flags & MAIL_STORAGE_SERVICE_FLAG_DEBUG) != 0)
 		(void)settings_parse_line(user->set_parser, "mail_debug=yes");
 
-	if ((flags & MAIL_STORAGE_SERVICE_FLAG_USERDB_LOOKUP) == 0) {
-		const char *home = getenv("HOME");
-		if (home != NULL)
-			set_keyval(ctx, user, "mail_home", home);
-	}
-
 	if (userdb_fields != NULL) {
 		int ret2 = auth_user_fields_parse(userdb_fields, temp_pool,
 						  &reply, &error);