From: Juliana Fajardini <jufajardini@gmail.com>
Date: Thu, 24 Feb 2022 16:04:36 +0000 (+0000)
Subject: applayer/frame: remove output from GetFrame funcs
X-Git-Tag: suricata-7.0.0-beta1~832
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e5838b8193c722b85e30edd108df7643b8abdd07;p=thirdparty%2Fsuricata.git

applayer/frame: remove output from GetFrame funcs

As these functions can be probed, having output there results in
misleading output.
---

diff --git a/src/app-layer-htp.c b/src/app-layer-htp.c
index 910121bd8d..315d267df8 100644
--- a/src/app-layer-htp.c
+++ b/src/app-layer-htp.c
@@ -194,7 +194,6 @@ static int HTTPGetFrameIdByName(const char *frame_name)
 {
     int id = SCMapEnumNameToValue(frame_name, http_frame_table);
     if (id < 0) {
-        SCLogError(SC_ERR_INVALID_ENUM_MAP, "unknown frame type \"%s\"", frame_name);
         return -1;
     }
     return id;
diff --git a/src/app-layer-ssl.c b/src/app-layer-ssl.c
index 73700f1af6..30ad2f7856 100644
--- a/src/app-layer-ssl.c
+++ b/src/app-layer-ssl.c
@@ -2769,7 +2769,6 @@ static int SSLStateGetFrameIdByName(const char *frame_name)
 {
     int id = SCMapEnumNameToValue(frame_name, tls_frame_table);
     if (id < 0) {
-        SCLogError(SC_ERR_INVALID_ENUM_MAP, "unknown frame type \"%s\"", frame_name);
         return -1;
     }
     return id;