From: Simon McVittie <smcv@collabora.com>
Date: Fri, 15 Jul 2022 11:14:45 +0000 (+0100)
Subject: meson: Comment why we disable certain compiler warnings
X-Git-Tag: dbus-1.15.0~28^2~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e5d2e402f9efec3214f52c51cb91077cefe8698b;p=thirdparty%2Fdbus.git

meson: Comment why we disable certain compiler warnings

This knowledge shouldn't be lost when we delete the Autotools build
system.

Signed-off-by: Simon McVittie <smcv@collabora.com>
---

diff --git a/meson.build b/meson.build
index 638bbf5fc..cc94bbde2 100644
--- a/meson.build
+++ b/meson.build
@@ -1012,8 +1012,14 @@ if cc.get_id() == 'msvc'
   ]
 else
   compile_warnings += [
+      # These warnings are intentionally disabled:
+      # - missing field initializers being implicitly 0 is a feature,
+      #   not a bug
+      # - -Wunused-parameter is annoying when writing callbacks that follow
+      #   a fixed signature but do not necessarily need all of its parameters
       '-Wno-missing-field-initializers',
       '-Wno-unused-parameter',
+
       '-Wchar-subscripts',
       '-Wfloat-equal',
   ]