From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Sat, 31 Oct 2020 17:24:47 +0000 (-0500)
Subject: Allow call to run with no children
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e5ea09161839e7fb608dc4ff1763eb99ed3d98b5;p=thirdparty%2Ffreeradius-server.git

Allow call to run with no children
---

diff --git a/src/lib/unlang/call.c b/src/lib/unlang/call.c
index 171f82389d0..7bcbcf28544 100644
--- a/src/lib/unlang/call.c
+++ b/src/lib/unlang/call.c
@@ -100,11 +100,14 @@ static unlang_action_t unlang_call(request_t *request, rlm_rcode_t *presult)
 	module_method_t		process_p;
 	void			*process_inst;
 
+	/*
+	 *	Do not check for children here.
+	 *
+	 *	Call shouldn't require children to execute as there
+	 *	can still be side effects from executing the virtual
+	 *	server.
+	 */
 	g = unlang_generic_to_group(instruction);
-	if (!g->num_children) {
-		*presult = RLM_MODULE_NOOP;
-		return UNLANG_ACTION_CALCULATE_RESULT;
-	}
 	gext = unlang_group_to_call(g);
 
 	server = cf_section_name2(gext->server_cs);