From: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Date: Fri, 27 May 2022 20:58:13 +0000 (-0600)
Subject: api: fix coverity warning about uninitialized variable
X-Git-Tag: v2.0.3~49
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e61a3ca6561068ccd31bb816477a8936a4b021e0;p=thirdparty%2Flibcgroup.git

api: fix coverity warning about uninitialized variable

CID 258269 (#1 of 1): Uninitialized scalar variable (UNINIT).
uninit_use: Using uninitialized value version.

In _cgroup_create_cgroup(), the (cg_version_t)version is uninitialized
and might be read the version in false path. It worked until now
because the version is assigned in the true path and given that its enum
the checks are not bounded by range, but rather specific.

Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
---

diff --git a/src/api.c b/src/api.c
index 99d8b944..5b945215 100644
--- a/src/api.c
+++ b/src/api.c
@@ -2431,7 +2431,7 @@ err:
  */
 int cgroup_create_cgroup(struct cgroup *cgroup, int ignore_ownership)
 {
-	enum cg_version_t version;
+	enum cg_version_t version = CGROUP_UNK;
 	char *fts_path[2];
 	char *base = NULL;
 	char *path = NULL;