From: Lennart Poettering <lennart@poettering.net>
Date: Thu, 12 Sep 2024 15:08:36 +0000 (+0200)
Subject: resolved: explicitly refuse adding invalid DNS names to DNS packets
X-Git-Tag: v257-rc1~121^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e63785611713cab0131599565cb3a1bb505640c7;p=thirdparty%2Fsystemd.git

resolved: explicitly refuse adding invalid DNS names to DNS packets

Fixes: #33671
---

diff --git a/src/resolve/resolved-dns-packet.c b/src/resolve/resolved-dns-packet.c
index 2684944b75e..c414ca800c3 100644
--- a/src/resolve/resolved-dns-packet.c
+++ b/src/resolve/resolved-dns-packet.c
@@ -564,6 +564,12 @@ int dns_packet_append_name(
         assert(p);
         assert(name);
 
+        r = dns_name_is_valid(name);
+        if (r < 0)
+                return r;
+        if (r == 0)
+                return -EINVAL;
+
         if (p->refuse_compression)
                 allow_compression = false;