From: Daniel Stenberg <daniel@haxx.se>
Date: Mon, 10 May 2004 08:57:18 +0000 (+0000)
Subject: better checking that strdup() works
X-Git-Tag: curl-7_12_0~152
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e64dacb40e3a32682a2481bedf83fd5f91cdde71;p=thirdparty%2Fcurl.git

better checking that strdup() works
---

diff --git a/lib/hash.c b/lib/hash.c
index 619f2fb1b3..fcc13ed28f 100644
--- a/lib/hash.c
+++ b/lib/hash.c
@@ -127,9 +127,17 @@ mk_hash_element(char *key, size_t key_len, const void *p)
     (curl_hash_element *) malloc(sizeof(curl_hash_element));
 
   if(he) {
-    he->key = strdup(key);
-    he->key_len = key_len;
-    he->ptr = (void *) p;
+    char *dup = strdup(key);
+    if(dup) {
+      he->key = dup;
+      he->key_len = key_len;
+      he->ptr = (void *) p;
+    }
+    else {
+      /* failed to duplicate the key, free memory and fail */
+      free(he);
+      he = NULL;
+    }
   }
   return he;
 }