From: Nick Mathewson <nickm@torproject.org>
Date: Wed, 10 Nov 2004 20:19:45 +0000 (+0000)
Subject: Remove XXXX009 comment telling us to do the last (circID-related) fix
X-Git-Tag: debian-version-0.0.8+0.0.9pre5-2~19
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e69d9647ed084dfde64f0e1bebbc98f8380c2cc6;p=thirdparty%2Ftor.git

Remove XXXX009 comment telling us to do the last (circID-related) fix


svn:r2798
---

diff --git a/src/or/circuitbuild.c b/src/or/circuitbuild.c
index 0bd8c01f57..63801982ae 100644
--- a/src/or/circuitbuild.c
+++ b/src/or/circuitbuild.c
@@ -350,15 +350,6 @@ circuit_deliver_create_cell(circuit_t *circ, char *payload) {
   tor_assert(circ->n_conn->type == CONN_TYPE_OR);
   tor_assert(payload);
 
-  /* XXXX009 How can we keep a good upgrade path here?  We should
-   * compare keys, not nicknames...but older servers will compare nicknames.
-   * Should we check server version from the most recent directory? Hm.
-   *
-   * This is important if anybody is unverified.
-   *
-   * Solution: switch to identity-based comparison, but if we get
-   * any circuits in the wrong half of the space, switch.
-   */
   circ->n_circ_id = get_unique_circ_id_by_conn(circ->n_conn);
   if(!circ->n_circ_id) {
     log_fn(LOG_WARN,"failed to get unique circID.");