From: Filip Schauer <f.schauer@proxmox.com>
Date: Mon, 15 Dec 2025 14:59:31 +0000 (+0100)
Subject: start: Remove outdated comment about group dropping
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e6ad17a796ae056337744980fb0719607a6be985;p=thirdparty%2Flxc.git

start: Remove outdated comment about group dropping

Commit b58214ac30bd (tree-wide: improve setgroups() dropping) moved the
group dropping code to occur before lxc_switch_uid_gid. Therefore this
comment is no longer correct.

Signed-off-by: Filip Schauer <f.schauer@proxmox.com>
---

diff --git a/src/lxc/start.c b/src/lxc/start.c
index 9311d6145..4927faf95 100644
--- a/src/lxc/start.c
+++ b/src/lxc/start.c
@@ -1307,9 +1307,6 @@ static int do_start(void *data)
 		if (!handler->conf->root_nsgid_map)
 			nsgid = handler->conf->init_gid;
 
-		/* Drop groups only after we switched to a valid gid in the new
-		 * user namespace.
-		 */
 		if (!lxc_drop_groups() &&
 		    (handler->am_root || errno != EPERM))
 			goto out_warn_father;