From: Victor Julien <victor@inliniac.net>
Date: Wed, 12 Jun 2019 05:45:38 +0000 (+0200)
Subject: stats: walk tv_root under lock
X-Git-Tag: suricata-5.0.0-rc1~404
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e6b633cf95d2aeb42251c0f45aecf2f728dfcbde;p=thirdparty%2Fsuricata.git

stats: walk tv_root under lock
---

diff --git a/src/counters.c b/src/counters.c
index 3880043c76..ac350a0719 100644
--- a/src/counters.c
+++ b/src/counters.c
@@ -478,6 +478,7 @@ static void *StatsWakeupThread(void *arg)
         SCCtrlCondTimedwait(tv_local->ctrl_cond, tv_local->ctrl_mutex, &cond_time);
         SCCtrlMutexUnlock(tv_local->ctrl_mutex);
 
+        SCMutexLock(&tv_root_lock);
         ThreadVars *tv = tv_root[TVT_PPT];
         while (tv != NULL) {
             if (tv->perf_public_ctx.head == NULL) {
@@ -511,6 +512,7 @@ static void *StatsWakeupThread(void *arg)
 
             tv = tv->next;
         }
+        SCMutexUnlock(&tv_root_lock);
 
         if (TmThreadsCheckFlag(tv_local, THV_KILL)) {
             break;