From: Volker Lendecke <vl@samba.org>
Date: Sun, 31 Aug 2008 09:34:01 +0000 (+0200)
Subject: Fix Coverity ID 592
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e6e8d108f95ed974f98f3f57adcfbbde4e00fad9;p=thirdparty%2Fsamba.git

Fix Coverity ID 592

The scanner did not figure out that we always have a primary domain, so it
complained about us potentially passing a NULL pointer down to
set_domain_online_request() where it is dereferenced.

Make the code a bit clearer.
---

diff --git a/source/winbindd/winbindd_dual.c b/source/winbindd/winbindd_dual.c
index 916e8c07c76..63ce0e8d7fb 100644
--- a/source/winbindd/winbindd_dual.c
+++ b/source/winbindd/winbindd_dual.c
@@ -1212,6 +1212,10 @@ static bool fork_domain_child(struct winbindd_child *child)
 		}
 	}
 
+	if (primary_domain == NULL) {
+		smb_panic("no primary domain found");
+	}
+
 	/* Ensure we're not handling an event inherited from
 	   our parent. */