From: Andrey Volk Date: Fri, 12 Jul 2019 16:09:36 +0000 (+0400) Subject: FS-11903: Fix errors reported by PVS-Studio Static Code Analyzer for mod_local_stream X-Git-Tag: v1.10.0~267 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e6f38bc6833fba5654dfd803103b080a1a2d4f91;p=thirdparty%2Ffreeswitch.git FS-11903: Fix errors reported by PVS-Studio Static Code Analyzer for mod_local_stream --- diff --git a/src/mod/formats/mod_local_stream/mod_local_stream.c b/src/mod/formats/mod_local_stream/mod_local_stream.c index d07bfb34f3..bb5fde7568 100644 --- a/src/mod/formats/mod_local_stream/mod_local_stream.c +++ b/src/mod/formats/mod_local_stream/mod_local_stream.c @@ -1106,7 +1106,7 @@ static switch_status_t local_stream_file_read_video(switch_file_handle_t *handle } if (context->source->banner_txt) { - if ((!context->banner_timeout || context->banner_timeout >= now)) { + if (!context->banner_timeout || context->banner_timeout >= now) { if (context->newres) { switch_img_free(&context->banner_img); context->newres = 0; @@ -1276,12 +1276,12 @@ static void launch_thread(const char *name, const char *path, switch_xml_t direc source->logo_pos = parse_img_position(val); } else if (!strcasecmp(var, "logo-opacity") && !zstr(val)) { source->logo_opacity = atoi(val); - if (source->logo_opacity < 0 && source->logo_opacity > 100) { + if (source->logo_opacity < 0 || source->logo_opacity > 100) { source->logo_opacity = 0; } } else if (!strcasecmp(var, "text-opacity") && !zstr(val)) { source->text_opacity = atoi(val); - if (source->text_opacity < 0 && source->text_opacity > 100) { + if (source->text_opacity < 0 || source->text_opacity > 100) { source->text_opacity = 0; } } else if (!strcasecmp(var, "volume")) {