From: Alan T. DeKok <aland@freeradius.org>
Date: Tue, 12 Sep 2023 18:21:06 +0000 (-0400)
Subject: just look at the dict, instead of calling common ancestor
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e70b7ce0aefe0d1736207bbd8d9317fc4f57b802;p=thirdparty%2Ffreeradius-server.git

just look at the dict, instead of calling common ancestor

because if we check for a common ancestor between a da and the
dict root, we're just checking if the da is in the dict.
---

diff --git a/src/lib/eap_aka_sim/encode.c b/src/lib/eap_aka_sim/encode.c
index eec1e477611..ee0a11ca9d0 100644
--- a/src/lib/eap_aka_sim/encode.c
+++ b/src/lib/eap_aka_sim/encode.c
@@ -74,12 +74,14 @@ static bool is_eap_aka_encodable(void const *item, UNUSED void const *uctx)
 
 	if (!vp) return false;
 	if (vp->da->flags.internal) return false;
+
 	/*
 	 *	Bool attribute presence is 'true' in SIM
 	 *	and absence is 'false'
 	 */
 	if ((vp->vp_type == FR_TYPE_BOOL) && (vp->vp_bool == false)) return false;
-	if (!fr_dict_attr_common_parent(fr_dict_root(dict_eap_aka_sim), vp->da, true)) return false;
+
+	if (vp->da->dict != dict_eap_aka_sim, vp->da) return false;
 
 	return true;
 }