From: Jamal Hadi Salim <jhs@mojatatu.com>
Date: Tue, 24 May 2016 11:52:48 +0000 (-0400)
Subject: tc simple action: bug fix
X-Git-Tag: v4.7.0~109
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e70b9f16ea5d461729e87e2b1ca927749bfb4f87;p=thirdparty%2Fiproute2.git

tc simple action: bug fix

Failed compile
m_simple.c: In function ‘parse_simple’:
m_simple.c:154:6: warning: too many arguments for format [-Wformat-extra-args]
      *argv);
      ^
m_simple.c:103:14: warning: unused variable ‘maybe_bind’ [-Wunused-variable]

Reported-by: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>
---

diff --git a/tc/m_simple.c b/tc/m_simple.c
index feba61b5d..27b3e5e40 100644
--- a/tc/m_simple.c
+++ b/tc/m_simple.c
@@ -100,7 +100,7 @@ parse_simple(struct action_util *a, int *argc_p, char ***argv_p, int tca_id,
 	struct tc_defact sel = {};
 	int argc = *argc_p;
 	char **argv = *argv_p;
-	int ok = 0, maybe_bind = 0;
+	int ok = 0;
 	struct rtattr *tail;
 	char *simpdata = NULL;
 
@@ -150,7 +150,7 @@ parse_simple(struct action_util *a, int *argc_p, char ***argv_p, int tca_id,
 		if (matches(*argv, "index") == 0) {
 			NEXT_ARG();
 			if (get_u32(&sel.index, *argv, 10)) {
-				fprintf(stderr, "simple: Illegal \"index\"\n",
+				fprintf(stderr, "simple: Illegal \"index\" (%s)\n",
 					*argv);
 				return -1;
 			}
@@ -171,7 +171,6 @@ parse_simple(struct action_util *a, int *argc_p, char ***argv_p, int tca_id,
 		return -1;
 	}
 
-
 	sel.action = TC_ACT_PIPE;
 
 	tail = NLMSG_TAIL(n);