From: Volker Lendecke Date: Fri, 25 Apr 2025 14:07:20 +0000 (+0200) Subject: libsmb: Simplify net_share_enum_rpc() with a direct struct initialization X-Git-Tag: tevent-0.17.0~202 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e71b9dda99b1f2e671d4c6e127c1400ff625d10d;p=thirdparty%2Fsamba.git libsmb: Simplify net_share_enum_rpc() with a direct struct initialization Signed-off-by: Volker Lendecke Reviewed-by: Stefan Metzmacher --- diff --git a/source3/libsmb/libsmb_dir.c b/source3/libsmb/libsmb_dir.c index 76733066ecf..2522f8d5bf6 100644 --- a/source3/libsmb/libsmb_dir.c +++ b/source3/libsmb/libsmb_dir.c @@ -354,8 +354,11 @@ net_share_enum_rpc(struct cli_state *cli, WERROR result; uint32_t preferred_len = 0xffffffff; uint32_t type; - struct srvsvc_NetShareInfoCtr info_ctr; - struct srvsvc_NetShareCtr1 ctr1; + struct srvsvc_NetShareCtr1 ctr1 = {}; + struct srvsvc_NetShareInfoCtr info_ctr = { + .level = 1, + .ctr.ctr1 = &ctr1, + }; fstring name = ""; fstring comment = ""; struct rpc_pipe_client *pipe_hnd = NULL; @@ -372,12 +375,6 @@ net_share_enum_rpc(struct cli_state *cli, goto done; } - ZERO_STRUCT(info_ctr); - ZERO_STRUCT(ctr1); - - info_ctr.level = 1; - info_ctr.ctr.ctr1 = &ctr1; - b = pipe_hnd->binding_handle; /* Issue the NetShareEnum RPC call and retrieve the response */