From: Victor Julien <vjulien@oisf.net>
Date: Tue, 25 Oct 2022 07:18:47 +0000 (+0200)
Subject: decode/vxlan/tests: don't memset new packet
X-Git-Tag: suricata-7.0.0-beta1~3
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e72770c1b27cce4cb1c13c7c1b252d8c39897348;p=thirdparty%2Fsuricata.git

decode/vxlan/tests: don't memset new packet
---

diff --git a/src/decode-vxlan.c b/src/decode-vxlan.c
index e73bc5642b..003154c6fb 100644
--- a/src/decode-vxlan.c
+++ b/src/decode-vxlan.c
@@ -212,16 +212,13 @@ static int DecodeVXLANtest01 (void)
     FAIL_IF_NULL(p);
     ThreadVars tv;
     DecodeThreadVars dtv;
-
-    DecodeVXLANConfigPorts(VXLAN_DEFAULT_PORT_S);
-
     memset(&tv, 0, sizeof(ThreadVars));
-    memset(p, 0, SIZE_OF_PACKET);
     memset(&dtv, 0, sizeof(DecodeThreadVars));
 
+    DecodeVXLANConfigPorts(VXLAN_DEFAULT_PORT_S);
     FlowInitConfig(FLOW_QUIET);
-    DecodeUDP(&tv, &dtv, p, raw_vxlan, sizeof(raw_vxlan));
 
+    DecodeUDP(&tv, &dtv, p, raw_vxlan, sizeof(raw_vxlan));
     FAIL_IF(p->udph == NULL);
     FAIL_IF(tv.decode_pq.top == NULL);
 
@@ -231,7 +228,7 @@ static int DecodeVXLANtest01 (void)
 
     FlowShutdown();
     PacketFree(p);
-    PacketFree(tp);
+    PacketFreeOrRelease(tp);
     PASS;
 }
 
@@ -254,16 +251,13 @@ static int DecodeVXLANtest02 (void)
     FAIL_IF_NULL(p);
     ThreadVars tv;
     DecodeThreadVars dtv;
-
-    DecodeVXLANConfigPorts("1");
-
     memset(&tv, 0, sizeof(ThreadVars));
-    memset(p, 0, SIZE_OF_PACKET);
     memset(&dtv, 0, sizeof(DecodeThreadVars));
 
+    DecodeVXLANConfigPorts("1");
     FlowInitConfig(FLOW_QUIET);
-    DecodeUDP(&tv, &dtv, p, raw_vxlan, sizeof(raw_vxlan));
 
+    DecodeUDP(&tv, &dtv, p, raw_vxlan, sizeof(raw_vxlan));
     FAIL_IF(p->udph == NULL);
     FAIL_IF(tv.decode_pq.top != NULL);