From: Greg Hudson <ghudson@mit.edu>
Date: Mon, 7 May 2018 02:29:40 +0000 (-0400)
Subject: Fix Leash build error with recent Visual Studio
X-Git-Tag: krb5-1.17-beta1~126
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e7315768eb52ad44e73ff1c51ef18fe5371412fc;p=thirdparty%2Fkrb5.git

Fix Leash build error with recent Visual Studio

Visual Studio 2015 and later do not allow manipulation of the _flag
field inside a file handle.  In Leash's out2con.cpp (used only for the
debugging -console flag), do not try to mark the allocated file handle
as free after copying it to *stdout; a one-time memory leak here is
unimportant.

ticket: 8679 (new)
---

diff --git a/src/windows/leash/out2con.cpp b/src/windows/leash/out2con.cpp
index f7a1d35a95..877eac14f1 100644
--- a/src/windows/leash/out2con.cpp
+++ b/src/windows/leash/out2con.cpp
@@ -96,9 +96,7 @@ ConsoleEcho::ConsoleEcho()
     FILE* fp = _fdopen(m_pipefd, "w");
     // copy to stdout
     *stdout = *fp;
-    // now slam the allocated FILE's _flag to zero to mark it as free without
-    // actually closing the os file handle and pipe
-    fp->_flag = 0;
+    // fp leaks, but we can't close it without closing the OS file handle
 
     // disable buffering
     setvbuf(stdout, NULL, _IONBF, 0);