From: Eric Wong <e@80x24.org>
Date: Sat, 16 Nov 2024 07:09:51 +0000 (+0000)
Subject: admin: autodie chdir + open
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e738b8660db54fd9c825a7303276987140f5eb1a;p=thirdparty%2Fpublic-inbox.git

admin: autodie chdir + open

autodie gives us more consistent error messages and reduces
visual noise on our end.  We can also open() directly into a
hash entry without relying on a temporary variable.
---

diff --git a/lib/PublicInbox/Admin.pm b/lib/PublicInbox/Admin.pm
index bb5d36532..fb745cf8e 100644
--- a/lib/PublicInbox/Admin.pm
+++ b/lib/PublicInbox/Admin.pm
@@ -6,6 +6,7 @@
 package PublicInbox::Admin;
 use v5.12;
 use parent qw(Exporter);
+use autodie qw(chdir open);
 our @EXPORT_OK = qw(setup_signals fmt_localtime);
 use PublicInbox::Config;
 use PublicInbox::Inbox;
@@ -313,9 +314,7 @@ sub progress_prepare ($;$) {
 		$opt->{quiet} = !$opt->{verbose};
 	}
 	if ($opt->{quiet}) {
-		open my $null, '>', '/dev/null' or
-			die "failed to open /dev/null: $!\n";
-		$opt->{1} = $null; # suitable for spawn() redirect
+		open $opt->{1}, '>', '/dev/null'; # suitable for spawn() redirect
 	} else {
 		$opt->{verbose} ||= 1;
 		$dst //= \*STDERR;
@@ -378,7 +377,7 @@ sub do_chdir ($) {
 	my $chdir = $_[0] // return;
 	for my $d (@$chdir) {
 		next if $d eq ''; # same as git(1)
-		chdir $d or die "cd $d: $!";
+		chdir $d;
 	}
 }