From: Jim Meyering <meyering@redhat.com>
Date: Sun, 28 Feb 2010 12:34:06 +0000 (+0100)
Subject: x86Decode: avoid NULL-dereference upon questionable input
X-Git-Tag: v0.7.7~43
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e749d776197f4d84babf0fac31c08ba5d44467fb;p=thirdparty%2Flibvirt.git

x86Decode: avoid NULL-dereference upon questionable input

* src/cpu/cpu_x86.c (x86Decode): Don't dereference NULL when passed
a NULL "models" pointer, or when passed a nonzero "nmodels" value
and a corresponding NULL models[i].
---

diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c
index 2194c32730..b263629a0d 100644
--- a/src/cpu/cpu_x86.c
+++ b/src/cpu/cpu_x86.c
@@ -998,7 +998,7 @@ x86Decode(virCPUDefPtr cpu,
         }
 
         for (i = 0; i < nmodels; i++) {
-            if (STREQ(models[i], candidate->name)) {
+            if (models && models[i] && STREQ(models[i], candidate->name)) {
                 allowed = true;
                 break;
             }