From: travis%sedsystems.ca <>
Date: Fri, 28 Jan 2005 03:50:25 +0000 (+0000)
Subject: Bug 278650 : editversions.cgi still uses "auth_cant_edit_versions"
X-Git-Tag: bugzilla-2.19.3~371
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e749f7333f0e2844f17d9b9011e1a13ed00ad121;p=thirdparty%2Fbugzilla.git

Bug 278650 : editversions.cgi still uses "auth_cant_edit_versions"
Patch by Frederic Buclin <LpSolit@gmail.com>  r=vladd  a=justdave
---

diff --git a/editversions.cgi b/editversions.cgi
index 613f2468af..e4cf47e2a1 100755
--- a/editversions.cgi
+++ b/editversions.cgi
@@ -115,11 +115,10 @@ Bugzilla->login(LOGIN_REQUIRED);
 
 print Bugzilla->cgi->header();
 
-unless (UserInGroup("editcomponents")) {
-    ThrowUserError('auth_cant_edit_versions');    
-    exit;
-}
-
+UserInGroup("editcomponents")
+  || ThrowUserError("auth_failure", {group  => "editcomponents",
+                                     action => "edit",
+                                     object => "versions"});
 
 #
 # often used variables
diff --git a/template/en/default/global/user-error.html.tmpl b/template/en/default/global/user-error.html.tmpl
index 5ea789a2fb..e849e78277 100644
--- a/template/en/default/global/user-error.html.tmpl
+++ b/template/en/default/global/user-error.html.tmpl
@@ -218,11 +218,6 @@
      Sorry, but you can not delete the default classification,
      '[% name FILTER html %]'.
 
-  [% ELSIF error == "auth_cant_edit_versions" %]
-    [% title = "Access Denied" %]
-    Sorry, you aren't a member of the 'editcomponents' group, and so
-    you aren't allowed to add, modify or delete versions.
-
   [% ELSIF error == "component_already_exists" %]
     [% title = "Component Already Exists" %]
     A component with the name '[% name FILTER html %]' already exists.